Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Temporarily disable website builds #13887

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Temporarily disable website builds #13887

merged 1 commit into from
Jan 15, 2019
+5 −4

Conversation

KellenSunderland
Copy link
Contributor

@KellenSunderland KellenSunderland commented Jan 15, 2019 •
edited
Loading

Description

Temporarily disable website builds. Work around for #13833.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

  • It seems it's difficult to disable a task within this pipeline as then we don't get a status report back. As a work around I've disabled the problematic document publishing piece rather than disabling the whole task.

@KellenSunderland
Copy link
Contributor Author

@larroy This looks like it properly disables flaky website builds. Does it look ok to you?

@marcoabreu
Copy link
Contributor

Possible duplicate of #13841

@aaronmarkham for approval

@KellenSunderland
Copy link
Contributor Author

KellenSunderland commented Jan 15, 2019 via email

@KellenSunderland
Copy link
Contributor Author

KellenSunderland commented Jan 15, 2019 via email

@larroy
Copy link
Contributor

larroy commented Jan 15, 2019

LGTM, I tried the same and status was not updated. I guess is an orthogonal issue.

@larroy
Copy link
Contributor

larroy commented Jan 15, 2019

#13841

@aaronmarkham
Copy link
Contributor

Is anyone looking at the underlying problem? Why are there OS errors? I checked the results of the last 30 builds. 16 failed with this error. It fails and different points during rendering the website from the markdown files, so I don't think it's content from the markdown - which by the way, builds just fine outside of CI.

@KellenSunderland
Copy link
Contributor Author

@larroy I think the trick is this PR just disables the flaky section. It still will report back a success to Jenkins after a simple build so it shouldn't get stuck with 'status not updated'.

@aaronmarkham Agree we should certainly look at why the failures are happening. Unless there's a trivial fix (and to my eyes there didn't appear to be) I'd recommend we disable this temporarily and investigate in parallel to unblock others.

aaronmarkham
aaronmarkham approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now... but let's figure out the underlying issue ASAP because all this will do is let more website errors slip in, and then we'll have to dig out of that hole later.

@stu1130
Copy link
Contributor

stu1130 commented Jan 15, 2019

@mxnet-label-bot add [pr-awaiting-merge]
Thanks for your contribution @KellenSunderland

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Jan 15, 2019
@larroy
Copy link
Contributor

larroy commented Jan 15, 2019

Is anyone looking at the underlying problem? Why are there OS errors? I checked the results of the last 30 builds. 16 failed with this error. It fails and different points during rendering the website from the markdown files, so I don't think it's content from the markdown - which by the way, builds just fine outside of CI.

I looked but couldn't reproduce the issue. Very difficult to diagnose without a reproduction, and with the autoscaling being enabled one can't get a hold of an instance where the job failed.

@KellenSunderland KellenSunderland merged commit 9d42812 into apache:master Jan 15, 2019
TaoLv added a commit to TaoLv/incubator-mxnet that referenced this pull request Jan 18, 2019
@TaoLv
Revert "Temporarily disable website testing (apache#13887)"
df55c1a 
This reverts commit 9d42812.
@TaoLv TaoLv mentioned this pull request Jan 18, 2019
Merged
7 tasks
marcoabreu pushed a commit that referenced this pull request Jan 18, 2019
@TaoLv @marcoabreu
Fix document build (#13927)
791c5d5 
* fix doc build

* Revert "Temporarily disable website testing (#13887)"

This reverts commit 9d42812.
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Jan 27, 2019
@TaoLv
Fix document build (apache#13927)
6a4dc19 
* fix doc build

* Revert "Temporarily disable website testing (apache#13887)"

This reverts commit 9d42812.
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@KellenSunderland @stephenrawls
Temporarily disable website testing (apache#13887)
552c442
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@TaoLv @stephenrawls
Fix document build (apache#13927)
8d2d318 
* fix doc build

* Revert "Temporarily disable website testing (apache#13887)"

This reverts commit 9d42812.
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@KellenSunderland
Temporarily disable website testing (apache#13887)
06182a1
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@TaoLv
Fix document build (apache#13927)
48e74b1 
* fix doc build

* Revert "Temporarily disable website testing (apache#13887)"

This reverts commit 9d42812.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronmarkham aaronmarkham aaronmarkham approved these changes

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KellenSunderland @marcoabreu @larroy @aaronmarkham @stu1130